Skip to content

More record skipping fuzz tests#2505

Merged
tustvold merged 1 commit intoapache:masterfrom
tustvold:more-record-skip-fuzz-tests
Aug 20, 2022
Merged

More record skipping fuzz tests#2505
tustvold merged 1 commit intoapache:masterfrom
tustvold:more-record-skip-fuzz-tests

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 18, 2022

Which issue does this PR close?

Closes #2475

#2504 from @thinkharderdev highlighted an omission in our fuzz test coverage, this fixes that.

Without the fix, this would fail, it now doesn't 🎉

Rationale for this change

What changes are included in this PR?

Increases the scenarios covered by the fuzz tests

Are there any user-facing changes?

This just updates tests

@tustvold tustvold added the development-process Related to development process of arrow-rs label Aug 18, 2022
@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 18, 2022
Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for the win! 😄

@tustvold tustvold merged commit cbaa2c0 into apache:master Aug 20, 2022
@ursabot
Copy link

ursabot commented Aug 20, 2022

Benchmark runs are scheduled for baseline = 7cfe3cf and contender = cbaa2c0. cbaa2c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of arrow-rs parquet Changes to the parquet crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate skip row without pageIndex in SerializedPageReader in Fuzz Test

3 participants