Skip to content

Fix Coverage/Mac/Windows CI#2280

Merged
alamb merged 1 commit intoapache:masterfrom
alamb:alamb/fix_ci_protoc
Aug 3, 2022
Merged

Fix Coverage/Mac/Windows CI#2280
alamb merged 1 commit intoapache:masterfrom
alamb:alamb/fix_ci_protoc

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 2, 2022 •
edited
Loading

Draft as I test and until I have restored the other workflows

Which issue does this PR close?

Closes #2279

Rationale for this change

The protobuf compiler, protoc needed for arrow-flight is no longer bundled with post, so we need to fix the github builders to have it

What changes are included in this PR?

  1. Install protoc correctly on windows builder
  2. Install protoc correctly on coverage builder (which can't use docker)

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 2, 2022
@alamb alamb mentioned this pull request Aug 2, 2022
Merged
@alamb alamb force-pushed the alamb/fix_ci_protoc branch from 60e1b9f to 46c8964 Compare August 2, 2022 21:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #2280 (737b10d) into master (b4fa47d) will decrease coverage by 0.07%.
The diff coverage is 92.72%.

❗ Current head 737b10d differs from pull request most recent head a3243c5. Consider uploading reports for the commit a3243c5 to get more accurate results

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
- Coverage   82.29%   82.21%   -0.08%     
==========================================
  Files         245      246       +1     
  Lines       62688    63367     +679     
==========================================
+ Hits        51586    52096     +510     
- Misses      11102    11271     +169
Impacted Files Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs 0.00% <0.00%> (ø)
arrow-flight/src/sql/arrow.flight.protocol.sql.rs 0.00% <ø> (ø)
object_store/src/aws.rs 0.00% <ø> (ø)
object_store/src/azure.rs 0.00% <ø> (ø)
object_store/src/gcp.rs 0.00% <ø> (ø)
object_store/src/lib.rs 86.75% <ø> (ø)
parquet/src/column/writer/mod.rs 92.85% <42.85%> (ø)
object_store/src/path/mod.rs 90.00% <50.00%> (-0.91%) ⬇️
arrow/src/array/array_decimal.rs 90.69% <88.31%> (-0.28%) ⬇️
parquet/src/encodings/levels.rs 94.23% <92.85%> (-0.03%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alamb alamb force-pushed the alamb/fix_ci_protoc branch from a3243c5 to c3b522c Compare August 2, 2022 22:00
@alamb alamb changed the title Fix Coverage/Mac/Windows CI (WIP) Fix Coverage/Mac/Windows CI Aug 2, 2022
@alamb alamb added the development-process Related to development process of arrow-rs label Aug 2, 2022
@alamb alamb marked this pull request as ready for review August 2, 2022 22:01
@alamb alamb mentioned this pull request Aug 2, 2022
Closed
@alamb
Copy link
Contributor Author

alamb commented Aug 3, 2022

Example mac run: https://github.com/apache/arrow-rs/runs/7641177466?check_suite_focus=true

Example coverage run: https://github.com/apache/arrow-rs/runs/7641178604?check_suite_focus=true

@alamb alamb merged commit 577a93b into apache:master Aug 3, 2022
@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = ec83638 and contender = 577a93b. 577a93b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@carols10cents carols10cents mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate development-process Related to development process of arrow-rs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows / Mac and Coverage jobs are no longer running: arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs

4 participants

@alamb @codecov-commenter @ursabot @tustvold