Skip to content

Complete and fixup split of arrow::array::builder module (#1843)#1928

Merged
tustvold merged 5 commits intoapache:masterfrom
tustvold:cleanup-builder-split
Jun 23, 2022
Merged

Complete and fixup split of arrow::array::builder module (#1843)#1928
tustvold merged 5 commits intoapache:masterfrom
tustvold:cleanup-builder-split

Conversation

@tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 23, 2022

Which issue does this PR close?

Closes #1843

Rationale for this change

See below

What changes are included in this PR?

Follow on to #1879 which

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 23, 2022
@tustvold tustvold changed the title Cleanup builder split Split up arrow::array::builder module (#1843) Jun 23, 2022
alamb
alamb reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks @tustvold

cc @DaltonModlin

@alamb alamb changed the title Split up arrow::array::builder module (#1843) Complete and fixup split of arrow::array::builder module (#1843) Jun 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #1928 (32cb25a) into master (9cd591d) will increase coverage by 0.01%.
The diff coverage is 58.15%.

❗ Current head 32cb25a differs from pull request most recent head 4225292. Consider uploading reports for the commit 4225292 to get more accurate results

@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
+ Coverage   83.41%   83.42%   +0.01%     
==========================================
  Files         214      217       +3     
  Lines       57004    56981      -23     
==========================================
- Hits        47550    47538      -12     
+ Misses       9454     9443      -11
Impacted Files Coverage Δ
arrow/src/array/builder/decimal_builder.rs 76.81% <0.00%> (+7.62%) ⬆️
arrow/src/array/builder/buffer_builder.rs 85.49% <9.09%> (-7.31%) ⬇️
...row/src/array/builder/fixed_size_binary_builder.rs 48.14% <48.14%> (ø)
arrow/src/array/builder/generic_binary_builder.rs 57.14% <57.14%> (ø)
arrow/src/array/array_binary.rs 94.18% <66.66%> (ø)
arrow/src/array/builder/generic_string_builder.rs 80.00% <80.00%> (ø)
arrow/src/array/builder/union_builder.rs 91.66% <87.50%> (+14.67%) ⬆️
arrow/src/array/data.rs 84.16% <100.00%> (ø)
parquet/src/encodings/encoding.rs 93.62% <0.00%> (+0.19%) ⬆️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd591d...4225292. Read the comment docs.

@tustvold
Copy link
Contributor Author

tustvold commented Jun 23, 2022

We also lost #1842

@tustvold tustvold merged commit 041e510 into apache:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split up arrow::array::builder module

3 participants

@tustvold @codecov-commenter @alamb