Skip to content

Split up arrow::array::builder module (#1843)#1879

Merged
alamb merged 2 commits intoapache:masterfrom
DaltonModlin:apache#1843
Jun 17, 2022
Merged

Split up arrow::array::builder module (#1843)#1879
alamb merged 2 commits intoapache:masterfrom
DaltonModlin:apache#1843

Conversation

@DaltonModlin
Copy link
Contributor

@DaltonModlin DaltonModlin commented Jun 15, 2022

Which issue does this PR close?

Closes #1843

Rationale for this change

Currently, arrow::array::builder contains 12 distinct builders; breaking the builders into submodules makes test coverage and functional differences more obvious.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 15, 2022
tustvold
tustvold reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍, I plan to go through this this evening unless someone else gets there first. Left some minor comments from a cursory run through.

Edit: CI appears to be unhappy

alamb
alamb approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @DaltonModlin

this PR appears to have a conflict -- could you possible resolve it and I will then merge it in?

Thanks!

@DaltonModlin
Split up arrow::array::builder module (apache#1843)
5686dad
@DaltonModlin
Split up arrow::array::builder module (apache#1843)
c7c6cb7 
- Removed old builder.rs
- Added missing licensing header to builder submodules
- Updated builder submodule imports and exports
- Updated array mod file builder imports and exports
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #1879 (c7c6cb7) into master (2e3d8dd) will decrease coverage by 0.01%.
The diff coverage is 86.97%.

@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
- Coverage   83.48%   83.47%   -0.02%     
==========================================
  Files         203      214      +11     
  Lines       57141    57163      +22     
==========================================
+ Hits        47705    47717      +12     
- Misses       9436     9446      +10
Impacted Files Coverage Δ
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/array/builder/decimal_builder.rs 69.18% <69.18%> (ø)
arrow/src/array/builder/boolean_builder.rs 75.75% <75.75%> (ø)
arrow/src/array/builder/union_builder.rs 76.99% <76.99%> (ø)
arrow/src/array/builder/struct_builder.rs 77.47% <77.47%> (ø)
.../src/array/builder/primitive_dictionary_builder.rs 78.18% <78.18%> (ø)
arrow/src/array/builder/map_builder.rs 81.63% <81.63%> (ø)
arrow/src/array/builder/fixed_size_list_builder.rs 87.61% <87.61%> (ø)
arrow/src/array/builder/primitive_builder.rs 91.88% <91.88%> (ø)
...row/src/array/builder/string_dictionary_builder.rs 92.23% <92.23%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3d8dd...c7c6cb7. Read the comment docs.

@alamb alamb merged commit 0a8deed into apache:master Jun 17, 2022
@alamb
Copy link
Contributor

alamb commented Jun 17, 2022

Thanks again @DaltonModlin

@DaltonModlin DaltonModlin deleted the apache#1843 branch June 17, 2022 20:05
tustvold added a commit to tustvold/arrow-rs that referenced this pull request Jun 23, 2022
@tustvold
Fix merge conflicts from (apache#1879)
2b34eb3
@tustvold tustvold mentioned this pull request Jun 23, 2022
Merged
tustvold added a commit that referenced this pull request Jun 23, 2022
@tustvold
Complete and fixup split of arrow::array::builder module (#1843) (#…
041e510 
…1928)

* Fix merge conflicts from (#1879)

* Split out of decimal_builder (#1843)

* Fix RAT

* Format

* Restore (#1842)
@tustvold tustvold mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tustvold tustvold tustvold left review comments

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

arrow Changes to the arrow crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split up arrow::array::builder module

4 participants

@DaltonModlin @codecov-commenter @alamb @tustvold