Implement UnionArray FieldData using Type Erasure#1842
Merged
tustvold merged 3 commits intoapache:masterfrom Jun 16, 2022
Merged
Implement UnionArray FieldData using Type Erasure#1842tustvold merged 3 commits intoapache:masterfrom
tustvold merged 3 commits intoapache:masterfrom
Conversation
tustvold
changed the title
tustvold
force-pushed
the
union-array-builder-strong-typing
branch
from
e9ace5e to
0b464c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
+ Coverage 83.49% 83.52% +0.02%
==========================================
Files 201 201
Lines 56903 56871 -32
==========================================
- Hits 47511 47499 -12
+ Misses 9392 9372 -20
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 16, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like a nice cleanup to me.
I also checked and this does not appear to change any of the public API, which is 👍
Co-authored-by: Andrew Lamb <[email protected]>
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this pull request
Jun 23, 2022
tustvold
added a commit
that referenced
this pull request
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on from #1591
Rationale for this change
mutable_buffer_to_buildercreated an untyped back-door to creating aBufferBuilder<T>with arbitraryMutableArray. This makes it hard to reason about the invariants of theMutableArraybelonging to aBufferBuilder.What changes are included in this PR?
This instead implements UnionArray using type-erasure, which is safer and less code.
Are there any user-facing changes?
No