Implement ChunkReader for Bytes, deprecate SliceableCursor#1775
Merged
alamb merged 1 commit intoapache:masterfrom Jun 3, 2022
Merged
Implement ChunkReader for Bytes, deprecate SliceableCursor#1775alamb merged 1 commit intoapache:masterfrom
ChunkReader for Bytes, deprecate SliceableCursor#1775alamb merged 1 commit intoapache:masterfrom
Conversation
Deprecate SliceableCursor
Codecov Report
@@ Coverage Diff @@
## master #1775 +/- ##
==========================================
- Coverage 83.39% 83.38% -0.02%
==========================================
Files 198 198
Lines 56142 56148 +6
==========================================
- Hits 46821 46818 -3
- Misses 9321 9330 +9
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 3, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I like where this is heading (less custom stuff in parquet-rs) 👍
| /// because the lack of Generic Associated Type implies that you would require complex lifetime propagation when | ||
| /// returning such a cursor. | ||
| #[allow(clippy::rc_buffer)] | ||
| #[deprecated = "use bytes::Bytes instead"] |
alamb
changed the title
ChunkReader for Bytes, deprecate SliceableCursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate SliceableCursor
Which issue does this PR close?
Part of #1163
Part of #1474
Rationale for this change
Better ecosystem interoperability, removes custom code, and may eventually allow eliding copies on read.
What changes are included in this PR?
Implement ChunkReader for Bytes and deprecates SliceableCursor
Are there any user-facing changes?
Deprecates an API