Remove null_count from ArrayData::try_new()#1721
Merged
viirya merged 1 commit intoapache:masterfrom May 22, 2022
Merged
Conversation
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1721 +/- ##
==========================================
- Coverage 83.32% 83.30% -0.02%
==========================================
Files 195 195
Lines 56044 55978 -66
==========================================
- Hits 46698 46635 -63
+ Misses 9346 9343 -3
Continue to review full report at Codecov.
|
tustvold
approved these changes
May 22, 2022
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Looks good to me, thank you 👍
viirya
approved these changes
May 22, 2022
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks good. Thanks @HaoYang670
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi [email protected]
Which issue does this PR close?
Closes #911.
Rationale for this change
Avoid the inconsistency of between
ArrayData::null_countandArrayData::null_nit_buffer.(Sadly, we could not do any simplification in
ArrayData::validate.)Are there any user-facing changes?
The API of
ArrayData::try_new()