Merged
Conversation
tustvold
approved these changes
May 12, 2022
viirya
approved these changes
May 12, 2022
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 83.10% 83.09% -0.01%
==========================================
Files 193 193
Lines 56011 56011
==========================================
- Hits 46547 46545 -2
- Misses 9464 9466 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
I plan to merge this when the test has completed |
Contributor
|
Just a small nit in PR description: |
Contributor
Author
|
Thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1695
Rationale for this change
I broke docs.rs build by merging #1349 without testing it first (shame on me!)
What changes are included in this PR?
Fix the build by removing unneeded part of 1349
I tested this by temporarily publishing an ancient version of parquet to crates.io from this branch https://github.com/alamb/arrow-rs/tree/alamb/test_crates_publish and verifying the docs built correctly
You can see the results here:
Are there any user-facing changes?
Docs will work correctly when published on crates.io
cc @HaoYang670 @viirya @tustvold