Nit: use the standard function div_ceil #1629
Merged
alamb merged 1 commit intoapache:masterfrom Apr 29, 2022
Merged
Conversation
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
- Coverage 83.03% 83.03% -0.01%
==========================================
Files 193 193
Lines 55472 55469 -3
==========================================
- Hits 46059 46056 -3
Misses 9413 9413
Continue to review full report at Codecov.
|
Dandandan
approved these changes
Apr 29, 2022
Contributor
|
Thanks @HaoYang670 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi [email protected]
Which issue does this PR close?
None. It is just a small change.
What changes are included in this PR?
We should use the standard function
div_ceilinstead of implementing our own.Are there any user-facing changes?
None