Prepare for arrow-rs 13.0.0 release#1624
Merged
alamb merged 8 commits intoapache:masterfrom Apr 29, 2022
Merged
Conversation
github-actions
bot
added
arrow
viirya
reviewed
Apr 28, 2022
CHANGELOG.md
Outdated
| - ListArray::from\(ArrayData\) dereferences invalid pointer when offsets are empty [\#1601](https://github.com/apache/arrow-rs/issues/1601) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] | ||
| - Incorrect nullable flag when reading maps \( test\_read\_maps fails when `force_validate` is active\) [\#1587](https://github.com/apache/arrow-rs/issues/1587) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] | ||
| - Output of `ipc::reader::tests::projection_should_work` fails validation [\#1548](https://github.com/apache/arrow-rs/issues/1548) [[arrow](https://github.com/apache/arrow-rs/labels/arrow)] | ||
| - Parquet: schema validation should allow scale == precision for decimal type [\#1607](https://github.com/apache/arrow-rs/pull/1607) [[parquet](https://github.com/apache/arrow-rs/labels/parquet)] ([sunchao](https://github.com/sunchao)) |
Member
There was a problem hiding this comment.
Isn't this the same with the first one Parquet schema should allow scale == precision for decimal type?
Contributor
Author
There was a problem hiding this comment.
Yes -- good call -- the script generates a line for every issue and PR marked bug -- I will remove the duplication. Thank you for the review @viirya
viirya
reviewed
Apr 28, 2022
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks good except one question.
Codecov Report
@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
+ Coverage 82.94% 83.03% +0.08%
==========================================
Files 193 193
Lines 55635 55472 -163
==========================================
- Hits 46148 46060 -88
+ Misses 9487 9412 -75
Continue to review full report at Codecov.
|
viirya
approved these changes
Apr 28, 2022
Contributor
Author
Contributor
Author
|
Merging this one in to create a release candidate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
re #1623
Rationale for this change
see subject
What changes are included in this PR?