Run rustdoc in CI and error if warnings#1266
Merged
alamb merged 7 commits intoapache:masterfrom Feb 8, 2022
Merged
Conversation
alamb
commented
Feb 3, 2022
alamb
commented
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 180 180
Lines 52269 52269
==========================================
- Hits 43398 43396 -2
- Misses 8871 8873 +2
Continue to review full report at Codecov.
|
This was referenced Feb 3, 2022
alamb
force-pushed
the
alamb/rustdoc_in_ci
branch
from
52581f8 to
1a6a882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Re #1267
closes #232
Rationale for this change
Once we have doc links fixed, ensure they don't get broken again by checking in CI
What changes are included in this PR?
Update the clippy check to also run
cargo docand fail on any warningsAre there any user-facing changes?
No