Revert making parquet::data_type and parquet::arrow::schema experimental#1244
Merged
alamb merged 1 commit intoapache:masterfrom Jan 28, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
=======================================
Coverage 82.95% 82.95%
=======================================
Files 178 178
Lines 51522 51522
=======================================
+ Hits 42740 42741 +1
+ Misses 8782 8781 -1
Continue to review full report at Codecov.
|
|
|
alamb
approved these changes
Jan 28, 2022
Contributor
|
Thank you for the report @pacman82 👍 |
|
You are welcome @alamb ! |
|
Thanks for merging! |
Contributor
|
This should be available in arrow 9.0.0 (scheduled for release in ~ Feb 7, 2022) -- I'll make an RC next friday and then it takes 3ish days to get approved |
alamb
changed the title
parquet::data_type and parquet::arrow::schema experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1032
Rationale for this change
#1134 was a tad overzealous and moved some functionality behind the experimental flags that downstream projects depend on.
What changes are included in this PR?
data_typeis made public, this is used by sqlite2parquet in order to interface with theColumnWriterAPIsI debated spending the time to instead mark the various bits of these modules experimental, but since the move to more frequent breaking releases (#1120) there seems to be limited value add from such an undertaking. The concept of experimental made sense when breaking changes were quarterly, now that they're biweekly...
Are there any user-facing changes?
No breaking changes, this can (and perhaps should be) a patch release.