Remove Copy trait bound from dyn scalar kernels#1243
Merged
alamb merged 1 commit intoapache:masterfrom Jan 27, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
==========================================
- Coverage 82.96% 82.95% -0.01%
==========================================
Files 178 178
Lines 51522 51522
==========================================
- Hits 42743 42742 -1
- Misses 8779 8780 +1
Continue to review full report at Codecov.
|
alamb
approved these changes
Jan 27, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Nice find @matthewmturner 👍
alamb
added
the
enhancement
alamb
changed the title
Copy trait requirement from dyn scalar kernels
alamb
changed the title
Copy trait requirement from dyn scalar kernelsCopy trait bound from dyn scalar kernels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No existing issue.
Rationale for this change
In the context of apache/datafusion#1685 I am trying to use datafusions
ScalarValuewith the dyn scalar kernels. We now use theToPrimitivetrait for the dyn scalar kernels and I am looking to implement that onScalarValueas well. While testing that locally the last issue i came across wasScalarValuenot implementingCopywhich the dyn scalar kernels require. I tried removing that constraint locally and had no issues compiling / testing / linting so im thinking the constraint isnt needed.@alamb FYI.
What changes are included in this PR?
Removing
Copytrait requirement on the dyn scalar kernels.Are there any user-facing changes?