Remove arrow array reader (#1197)#1234
Merged
alamb merged 2 commits intoapache:masterfrom Jan 24, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
+ Coverage 82.82% 82.94% +0.11%
==========================================
Files 179 178 -1
Lines 52170 51346 -824
==========================================
- Hits 43210 42589 -621
+ Misses 8960 8757 -203
Continue to review full report at Codecov.
|
Contributor
|
|
alamb
approved these changes
Jan 24, 2022
Contributor
|
Thanks @yordan-pavlov and @tustvold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is preventing fixing #1230 and interfering with progress on #1154 and #1225 and so I think the time has come to remove this.
Closes #1197.
Rationale for this change
See ticket
What changes are included in this PR?
Removes ArrowArrayReader
Are there any user-facing changes?
No, this was made an experimental API in #1134
FYI @yordan-pavlov