Repository navigation
Use fallible MutableBuffer methods in fallible APIs - #11973
Rich-T-kid wants to merge 5 commits into
Conversation
8f3cd54 to
ba91f64
Compare
21c11b4 to
9db65b0
Compare
9db65b0 to
dd8c427
Compare
dd8c427 to
e2861aa
Compare
|
run benchmark mutable_array |
|
run benchmark zip_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: mutable_array Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark mutable_array
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark filter_kernels |
|
run benchmark interleave_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: zip_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark zip_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark concatenate_kernel |
|
run benchmark merge_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: interleave_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark interleave_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: filter_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark filter_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark take_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: merge_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark merge_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: concatenate_kernel Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: mutable_array Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark mutable_array
shards: 1
DetailsPer-runner informationmutable_array — shard 1/1Node: gk3-benchmark-cluster-nap-17zlehta-9030ffee-2pz8 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench mutable_arrayCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: concatenate_kernel Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
DetailsPer-runner informationconcatenate_kernel — shard 1/1Node: gk3-benchmark-cluster-nap-17zlehta-9030ffee-twwq Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench concatenate_kernelCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: take_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: interleave_kernels Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark interleave_kernels
shards: 1
DetailsPer-runner informationinterleave_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-1ltj1dko-fe0a3f66-5ms7 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench interleave_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: take_kernels Comparing rich-T-kid/mutable-array-data-fallible (e2861aa) to a1e8df8 (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
DetailsPer-runner informationtake_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-17zlehta-9030ffee-twwq Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
run benchmark concatenate_kernel |
|
🤖 Benchmark starting (GKE) | trigger Target: zip_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark zip_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark filter_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: concatenate_kernel Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark interleave_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: filter_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark filter_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark mutable_array |
|
run benchmark take_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: interleave_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark interleave_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark merge_kernels |
|
🤖 Benchmark starting (GKE) | trigger Target: mutable_array Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark mutable_array
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: take_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: mutable_array Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark mutable_array
shards: 1
DetailsPer-runner informationmutable_array — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-r7t5 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench mutable_arrayCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: concatenate_kernel Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
DetailsPer-runner informationconcatenate_kernel — shard 1/1Node: gk3-benchmark-cluster-nap-1mlzckca-c7d66e25-q7f2 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench concatenate_kernelCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: merge_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark merge_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark concatenate_kernel |
|
🤖 Benchmark completed (GKE) | trigger Target: take_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
DetailsPer-runner informationtake_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-vlt2 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: concatenate_kernel Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
run benchmark take_kernels |
|
🤖 Benchmark completed (GKE) | trigger Target: interleave_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark interleave_kernels
shards: 1
DetailsPer-runner informationinterleave_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-xhn5 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench interleave_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: concatenate_kernel Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark concatenate_kernel
shards: 1
DetailsPer-runner informationconcatenate_kernel — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-vlt2 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench concatenate_kernelCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: take_kernels Sharding factor: 1 (1 workers). Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: filter_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark filter_kernels
shards: 1
DetailsPer-runner informationfilter_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-7j42 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench filter_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: take_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark take_kernels
shards: 1
DetailsPer-runner informationtake_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-vlt2 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: zip_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark zip_kernels
shards: 1
DetailsPer-runner informationzip_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-37wszl0h-8facf7d7-28hh Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench zip_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: merge_kernels Comparing rich-T-kid/mutable-array-data-fallible (281d0f0) to 739f9cc (merge-base) diff Run configurationrun benchmark merge_kernels
shards: 1
DetailsPer-runner informationmerge_kernels — shard 1/1Node: gk3-benchmark-cluster-nap-1mlzckca-c7d66e25-q7f2 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench merge_kernelsCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Which issue does this PR address?
Closes #11900, following #11912.
What changes are included in this PR?
Replace panicking buffer calls inside existing fallible APIs with their direct fallible equivalents:
OffsetBuffer::try_new_zeroed(0)for the emptytry_from_repeated_lengthcase.MutableBuffer::try_extend_from_slicefor sparse and dense union type IDs.ArrowError::MemoryError.There are no changes to
MutableArrayDataorchestration or output semantics.