Conversation
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 49383 49420 +37
=======================================
+ Hits 40649 40681 +32
- Misses 8734 8739 +5
Continue to review full report at Codecov.
|
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
@liukun4515 I looked at this PR and the code looks good. I think all it needs now is some tests and a rebase and it would be good to go.
I plan to create an arrow 6.5.0 release candidate tomorrow (Thursday) -- let me know if you think we should aim to get this PR merged before doing so.
arrow/src/compute/kernels/cast.rs
Outdated
| let input_type = DataType::Decimal(20, 3); | ||
| let output_type = DataType::Decimal(20, 4); | ||
| assert!(can_cast_types(&input_type, &output_type)); | ||
| // let array = vec![Some(1123456), Some(2123456), Some(3123456), None]; |
There was a problem hiding this comment.
looks like we just need some tests here, and we'll be all set 👍
I rebased this branch with master and added some test cases. |
|
Thanks @liukun4515 ❤️ |
* support cast decimal to decimal * add test case * remove meaningless code
* support cast decimal to decimal * add test case * remove meaningless code Co-authored-by: Kun Liu <[email protected]>
4 participants
Which issue does this PR close?
part of #1043
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?