Repository navigation
introduce GenericByteDictionaryBuilder::append_array() - #10765
Merged
Jefffrey merged 5 commits intoAug 24, 2026
Merged
Conversation
github-actions
Bot
added
arrow
Contributor
Author
|
run benchmark cast_kernels env: |
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 19, 2026 20:58
14e35c9 to
33cded2
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
|
Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10765 (comment)). Error: Usage: Any benchmark name is accepted: Per-side configuration ( env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2GFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
Hi @Rich-T-kid, your benchmark configuration could not be parsed (#10765 (comment)). Error: Usage: Any benchmark name is accepted: Per-side configuration ( env:
# shared env is inherited by BOTH the build and the run, so build
# flags go here. Builds default to no debuginfo for speed; opt back
# in for hung-job gdb dumps and cap jobs to stay within memory:
CARGO_PROFILE_RELEASE_DEBUG: "1"
CARGO_BUILD_JOBS: "1"
baseline:
ref: v45.0.0
env:
# per-side env only reaches the benchmark run, not the build
DATAFUSION_RUNTIME_MEMORY_LIMIT: 1G
changed:
ref: v46.0.0
env:
DATAFUSION_RUNTIME_MEMORY_LIMIT: 2GFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
show benchmark queue |
|
Hi @Rich-T-kid, you asked to view the benchmark queue (#10765 (comment)).
File an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (33cded2) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels env: |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
run benchmark cast_kernels |
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Author
|
show benchmark queue |
|
Hi @Rich-T-kid, you asked to view the benchmark queue (#10765 (comment)).
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (d6a16fb) to 6bb5e2b (merge-base) diff Run configurationrun benchmark cast_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
🚀 |
Rich-T-kid
force-pushed
the
rich-T-kid/bench-dict-append-array-impl
branch
from
August 20, 2026 01:05
d6a16fb to
faca997
Compare
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (a717d1d) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (a717d1d) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (a717d1d) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
bot seems to be working again, atleast on other PRs 😄 |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (a717d1d) to 7ec3f5a (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Contributor
Author
|
run benchmark cast_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing rich-T-kid/bench-dict-append-array-impl (f22a006) to cd7c6b8 (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"BENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench cast_kernels File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing rich-T-kid/bench-dict-append-array-impl (f22a006) to cd7c6b8 (merge-base) diff Run configurationrun benchmark cast_kernels
env:
BENCH_FILTER: "cast binary to dict"CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Contributor
Author
nice! @Jefffrey numbers look decent again |
Jefffrey
changed the title
GenericByteDictionaryBuilder::append_array()
Jefffrey
approved these changes
Aug 24, 2026
Contributor
|
thanks @Rich-T-kid |
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Aug 26, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Aug 28, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Sep 2, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Sep 18, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Sep 21, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
Rich-T-kid
added a commit
to Rich-T-kid/arrow-rs
that referenced
this pull request
Sep 25, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes apache#10762. # Rationale for this change the utf8/binary -> dict<_,utf8/binary> currently calls `append_value()` in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? new `append_array()` method on the byteDictionaryBuilder. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes & benchmarked <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, new `append_array()` method on the byteDictionaryBuilder. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
the utf8/binary -> dict<_,utf8/binary> currently calls
append_value()in a loop even when it has the entire array ahead of time. this PR avoids that by working with th entire array at once as well as branching on weather or not the array contains nulls.What changes are included in this PR?
new
append_array()method on the byteDictionaryBuilder.Are these changes tested?
yes & benchmarked
Are there any user-facing changes?
yes, new
append_array()method on the byteDictionaryBuilder.