# Which issue does this PR close? - Closes #8182 (directly) - Closes #8170 (as a side effect) - Closes #8180 (as a side effect) # Rationale for this change Make finish/rollback handling simpler, robust and uniform by pulling it inside `ParentState` (instead of each builder doing it manually) and making it fully eager (instead of a mix of eager and lazy). # What changes are included in this PR? See above. # Are these changes tested? Yes, existing unit tests cover it (including some that needed adjustment due to behavior changes), along with some new testing. # Are there any user-facing changes? `ObjectBuilder` methods `new_list` and `new_object` now panic if a duplicate field name is provided, and new fallible versions `try_new_list` and `try_new_object` are provided. `ObjectBuilder::finish` signature remains fallible, but it always returns `Result::Ok` * TODO: #8184 Existing `VariantBuilderExt` methods `new_list` and `new_object` now panic if they encounter a duplicate field name; new fallible versions `try_new_list` and `try_new_object` are provided.

Make ObjectBuilder::finish signature infallible #8184

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Make `ObjectBuilder::finish` signature infallible #8184