-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow cratearrow-avroarrow-avro cratearrow-avro crategood first issueGood for newcomersGood for newcomers
Description
I think it would be better to use methods from the tempfile crate here, as is done elsewhere in this repo.
Specifically in arrow-avro/src/writer/mod.rs we should remove this code
arrow-rs/arrow-avro/src/writer/mod.rs
Lines 223 to 231 in 4bb9127
| fn unique_temp_path(prefix: &str) -> std::path::PathBuf { | |
| let mut p = std::env::temp_dir(); | |
| let nanos = std::time::SystemTime::now() | |
| .duration_since(std::time::UNIX_EPOCH) | |
| .unwrap() | |
| .as_nanos(); | |
| p.push(format!("{}_{}_{}.avro", prefix, std::process::id(), nanos)); | |
| p | |
| } |
And replace it with tempfile
For example:
Originally posted by @alamb in #8123 (comment)
jecsand838
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow cratearrow-avroarrow-avro cratearrow-avro crategood first issueGood for newcomersGood for newcomers