Skip to content

Add Dense/Sparse annotation to DataType::Union #814

@alamb

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
While working on validation for ArrayData (#810), I was trying to validate that the number of Buffers passed to a UnionArray were accurate.

However, since number of Buffers for a UnionArray differs based on if it has a "sparse" or "dense" layout (1 or 2, respectively), the sparseness for the UnionArray is not encoded in the typeDataType::UnionArray; This means we can't easily validate that the UnionArray has the correct number of buffers for its type

It also means that the UnionArray can not be used without first checking to see how many buffers it has (what type it is)

Describe the solution you'd like
I propose changing

enum DataType {
..
  Union(Vec<Field>),
..
}

To something like

enum UnionMode {
  Sparse,
  Dense
}

enum DataType {
..
  Union(UnionMode, Vec<Field>),
..
}

which is both consistent with the C++ implementation as well as allows UnionArray to be statically typechecked: https://github.com/apache/arrow/blob/661c7d749150905a63dd3b52e0a04dac39030d95/cpp/src/arrow/type.h#L1028

Describe alternatives you've considered
Can keep the sparse/dense

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    api-changeChanges to the arrow APIarrowChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelog

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions