You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Release arrow-rs / parquet minor version 54.2.0 (~Mar~ Feb 2025) #7083
changed the title [-]Release arrow-rs / parquet minor version 54.2.0 (Feb 2025)[/-][+]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/+]on Feb 6, 2025
changed the title [-]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/-][+]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/+]on Feb 6, 2025
changed the title [-]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/-][+]Release arrow-rs / parquet minor version `54.2.0` (~Mar~ Feb 2025)[/+]on Feb 10, 2025
It turns out that arrow has rand in the public API as part of the bench_util and I got a few compile errors like
error[E0599]: the method `gen` exists for struct `StdRng`, but its trait bounds were not satisfied
--> datafusion/functions-aggregate/benches/array_agg.rs:64:27
|
64 | let is_null = rng.gen::<f32>() < null_density;
| ^^^ method cannot be called on `StdRng` due to unsatisfied trait bounds
|
::: /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.9.0/src/rngs/std.rs:70:1
|
70 | pub struct StdRng(Rng);
| ----------------- doesn't satisfy `rand::rngs::std::StdRng: rand::RngCore` or `rand::rngs::std::StdRng: rand::Rng`
|
= note: the following trait bounds were not satisfied:
`rand::rngs::std::StdRng: rand::RngCore`
which is required by `rand::rngs::std::StdRng: rand::Rng`
= help: items from traits can only be used if the trait is in scope
help: trait `Rng` which provides `gen` is implemented but not in scope; perhaps you want to import it
|
18 + use rand::rng::Rng;
There are two potential solutions I can think of
(the nicest) revert the upgrade to rand
(the easiest) Publicly export rand so the correct version can be used in the API
Activity
alamb commentedon Feb 6, 2025
Realistically I can't do both this release and the object store on the same week
0.12.0(API breaking) Around Feb 30 2025 arrow-rs-object-store#28[-]Release arrow-rs / parquet minor version 54.2.0 (Feb 2025)[/-][+]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/+][-]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/-][+]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/+]alamb commentedon Feb 10, 2025
We have discovered a regression
@Blizzara has requested a release with this fix
I therefore plan to make a 54.2.0 release later this week
[-]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/-][+]Release arrow-rs / parquet minor version `54.2.0` (~Mar~ Feb 2025)[/+]alamb commentedon Feb 10, 2025
Since
mainis still the54.xline and the fix has already been mergedI'll plan to make a release directly from main
FYI @tustvold and @Jefffrey @etseidl
alamb commentedon Feb 12, 2025
I tested the pre-release update of 54.2.0 with DataFusion
arrow/parquet54.2.0 datafusion#14628It turns out that arrow has
randin the public API as part of thebench_utiland I got a few compile errors likeThere are two potential solutions I can think of
randso the correct version can be used in the APII am going to make a PR for 2
tustvold commentedon Feb 12, 2025
Won't that still be a breaking change?
alamb commentedon Feb 12, 2025
Yes
tustvold commentedon Feb 12, 2025
In which case it can't be released as 54.2.0?
Edit: I don't see a way to avoid reverting #7045
alamb commentedon Feb 12, 2025
Yes I suppose you are right -- I will prepare some PRs to do so
alamb commentedon Feb 12, 2025
Here is a revert PR:
alamb commentedon Feb 12, 2025
Ok, I reverted the rand upgrade and verified the datafusion upgrade went smoothly:
arrow/parquet54.2.0 datafusion#14628alamb commentedon Feb 12, 2025
I am working on updating the release notes and will prepare an RC
alamb commentedon Feb 12, 2025
I have created a release candidate and begun the voting:
alamb commentedon Feb 16, 2025
The release was approved and published to crates.io
https://lists.apache.org/thread/llb2y438llx5p6kxtg5wwhblgnvok3zy