Skip to content

Release arrow-rs / parquet minor version 54.2.0 (~Mar~ Feb 2025) #7083

Closed

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Our release schedule is here https://github.com/apache/arrow-rs?tab=readme-ov-file#release-versioning-and-schedule

Items to fix before the release:

Wishlist Items

Describe the solution you'd like

Create a release

Describe alternatives you've considered

Additional context

Activity

  1. alamb commented on Feb 6, 2025

    @alamb
    ContributorAuthor

    Realistically I can't do both this release and the object store on the same week

  2. changed the title [-]Release arrow-rs / parquet minor version 54.2.0 (Feb 2025)[/-] [+]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/+] on Feb 6, 2025
  3. changed the title [-]Release arrow-rs / parquet minor version 54.2.0 (Mar 2025)[/-] [+]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/+] on Feb 6, 2025
  4. alamb commented on Feb 10, 2025

    @alamb
    ContributorAuthor
  5. changed the title [-]Release arrow-rs / parquet minor version `54.2.0` (Mar 2025)[/-] [+]Release arrow-rs / parquet minor version `54.2.0` (~Mar~ Feb 2025)[/+] on Feb 10, 2025
  6. alamb commented on Feb 10, 2025

    @alamb
    ContributorAuthor

    Since main is still the 54.x line and the fix has already been merged

    I'll plan to make a release directly from main

    FYI @tustvold and @Jefffrey @etseidl

  7. self-assigned this
    on Feb 10, 2025
  8. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor

    I tested the pre-release update of 54.2.0 with DataFusion

    It turns out that arrow has rand in the public API as part of the bench_util and I got a few compile errors like

    error[E0599]: the method `gen` exists for struct `StdRng`, but its trait bounds were not satisfied
      --> datafusion/functions-aggregate/benches/array_agg.rs:64:27
       |
    64 |         let is_null = rng.gen::<f32>() < null_density;
       |                           ^^^ method cannot be called on `StdRng` due to unsatisfied trait bounds
       |
      ::: /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rand-0.9.0/src/rngs/std.rs:70:1
       |
    70 | pub struct StdRng(Rng);
       | ----------------- doesn't satisfy `rand::rngs::std::StdRng: rand::RngCore` or `rand::rngs::std::StdRng: rand::Rng`
       |
       = note: the following trait bounds were not satisfied:
               `rand::rngs::std::StdRng: rand::RngCore`
               which is required by `rand::rngs::std::StdRng: rand::Rng`
       = help: items from traits can only be used if the trait is in scope
    help: trait `Rng` which provides `gen` is implemented but not in scope; perhaps you want to import it
       |
    18 + use rand::rng::Rng;
    

    There are two potential solutions I can think of

    1. (the nicest) revert the upgrade to rand
    2. (the easiest) Publicly export rand so the correct version can be used in the API

    I am going to make a PR for 2

  9. tustvold commented on Feb 12, 2025

    @tustvold
    Contributor

    I am going to make a PR for 2

    Won't that still be a breaking change?

  10. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor

    I am going to make a PR for 2

    Won't that still be a breaking change?

    Yes

  11. tustvold commented on Feb 12, 2025

    @tustvold
    Contributor

    In which case it can't be released as 54.2.0?

    Edit: I don't see a way to avoid reverting #7045

  12. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor

    In which case it can't be released as 54.2.0?

    Edit: I don't see a way to avoid reverting #7045

    Yes I suppose you are right -- I will prepare some PRs to do so

  13. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor
  14. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor

    Ok, I reverted the rand upgrade and verified the datafusion upgrade went smoothly:

  15. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor

    I am working on updating the release notes and will prepare an RC

  16. alamb commented on Feb 12, 2025

    @alamb
    ContributorAuthor
  17. alamb commented on Feb 16, 2025

    @alamb
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions