You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
functions in temporal_conversions do not handle negative integers correctly #593
Describe the bug
From my testing, it appears that functions in temporal_conversions do not handle negative integers correctly. The cast of a negative number to a u32 results in a junk value that causes chrono to panic.
Expected behavior
The conversion functions should handle timestamps before the epoch correctly.
Additional context
I discovered this via the Debug impl for a Timestamp column type. Other basic operations on the column w/ negative timestamps seem to work without a problem, but I haven't tested thoroughly.
Activity
FauxFaux commentedon Dec 30, 2021
Semi-related; these functions probably shouldn't panic at all?
In my case, an invalid (too big) Time value (was supposed to be a Timestamp) caused a ("production") panic.
Jefffrey commentedon Dec 9, 2022
Resolved by #2326