-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently the following test case(s) will fail:
#[test]
fn test_utf8_view_eq() {
let values = vec![Some("small"), None, Some("larger than 12 bytes string")];
let left = StringViewArray::from_iter(values.iter());
let right = StringViewArray::from_iter(values.iter());
crate::cmp::eq(&left, &right).unwrap();
}Because we haven't implemented the code to compare two view types in compare_op https://github.com/XiangpengHao/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L227
I believe this is required to unblock apache/datafusion#10919
Describe the solution you'd like
The solution should be fairly simple.
Describe alternatives you've considered
Additional context
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog