Skip to content

Implement compare_op for GenericBinaryView  #5897

@XiangpengHao

Description

@XiangpengHao

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently the following test case(s) will fail:

    #[test]
    fn test_utf8_view_eq() {
        let values = vec![Some("small"), None, Some("larger than 12 bytes string")];
        let left = StringViewArray::from_iter(values.iter());
        let right = StringViewArray::from_iter(values.iter());
        crate::cmp::eq(&left, &right).unwrap();
    }

Because we haven't implemented the code to compare two view types in compare_op https://github.com/XiangpengHao/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L227

I believe this is required to unblock apache/datafusion#10919

Describe the solution you'd like

The solution should be fairly simple.

Describe alternatives you've considered

Additional context

Metadata

Metadata

Assignees

Labels

arrowChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelog

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions