Skip to content

ArrowArrayStreamReader imports FFI_ArrowSchema on each iteration #5103

New issue
New issue
Closed
#5248
Closed
ArrowArrayStreamReader imports FFI_ArrowSchema on each iteration#5103
#5248
Labels
arrowChanges to the arrow crateperformance
@pitrou

Description

@pitrou
pitrou
opened on Nov 20, 2023

The next method of ArrowArrayStreamReader always re-exports the already imported Schema, to re-import it immediately afterwards:

arrow-rs/arrow/src/ffi_stream.rs

Lines 360 to 362 in 4d141a3

let schema = FFI_ArrowSchema::try_from(schema_ref.as_ref()).ok()?;
let data = from_ffi(array, &schema).ok()?;

It would be less wasteful to pass the existing Schema to the internal FFI routines.

Metadata

Metadata

Assignees

No one assigned

    Labels

    arrowChanges to the arrow crateperformance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions