For anyone else reading this issue, all the calls to *Array::value() I checked (below) had bounds checking in them and would panic if an out of bounds request was made.

As written, the ticket seems more broadly defined and refers to more than just value() so I'll leave it open, but at the moment this seems unactionable to me (as the methods needing bounds checking are not clear).

BinaryArray: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/array/array_binary.rs?L104&subtree=true

ListArray: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/array/array_list.rs?L83:9&subtree=true

PrimitiveArray: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/array/array_primitive.rs?L119:9&subtree=true

StringArray: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/array/array_string.rs?L108:9&subtree=true

BooleanArray: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/array/array_boolean.rs?L119:9&subtree=true

Mark methods that do not perform bounds checking as unsafe #29

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions