-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogquestionFurther information is requestedFurther information is requested
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
All Array implementations must implement the JsonEqual trait. However:
- UnionArray will always panic
- DictionaryArray is incorrect (JsonEqual for DictionaryArray Only Compares Keys #2294)
- It is unclear to me why we would special case JSON
- It complicates making JSON an optional feature
Describe the solution you'd like
Rather than maintaining parallel logic to interpret serde_json::Value as arrow arrays, I wonder if we can just remove the JsonEqual functionality and encourage conversion to arrow arrays. I'm unclear of a use-case that would require highly-performant comparison of arrow and JSON data
Describe alternatives you've considered
Additional context
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow crateenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogquestionFurther information is requestedFurther information is requested