Skip to content

JsonEqual for DictionaryArray Only Compares Keys #2294

@tustvold

Description

@tustvold

Describe the bug

impl<T: ArrowPrimitiveType> JsonEqual for DictionaryArray<T> {
    fn equals_json(&self, json: &[&Value]) -> bool {
        // todo: this is wrong: we must test the values also
        self.keys().equals_json(json)
    }
}

To Reproduce

Expected behavior

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    arrowChanges to the arrow cratebug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions