Skip to content

Add CI check for full validation mode #1544

@alamb

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We have a full validation mode that validates the full contents of creating Arrays but it is (on purpose) not called in many places in arrow for performance reasons: https://docs.rs/arrow/11.1.0/arrow/array/struct.ArrayData.html#method.validate_full

This leads to two possible issues:

  1. Lack of teset coverage of arrays constructed within arrow
  2. Possible Lack of test coverage of the validation routine itself

Describe the solution you'd like

  1. Add a feature flag that forced the validation check for all array creations (defaults to off)
  2. Add a new CI check that runs with this flag on

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    arrowChanges to the arrow cratedevelopment-processRelated to development process of arrow-rsenhancementAny new improvement worthy of a entry in the changelog

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions