-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
arrowChanges to the arrow crateChanges to the arrow cratedevelopment-processRelated to development process of arrow-rsRelated to development process of arrow-rsenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have a full validation mode that validates the full contents of creating Arrays but it is (on purpose) not called in many places in arrow for performance reasons: https://docs.rs/arrow/11.1.0/arrow/array/struct.ArrayData.html#method.validate_full
This leads to two possible issues:
- Lack of teset coverage of arrays constructed within arrow
- Possible Lack of test coverage of the validation routine itself
Describe the solution you'd like
- Add a feature flag that forced the validation check for all array creations (defaults to off)
- Add a new CI check that runs with this flag on
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arrowChanges to the arrow crateChanges to the arrow cratedevelopment-processRelated to development process of arrow-rsRelated to development process of arrow-rsenhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelog