You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Handle the timezone in extract week in temporal.rs #1380
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
/// Extracts the week of a given temporal array as an array of integers
pub fn week<T>(array: &PrimitiveArray<T>) -> Result<Int32Array>
where
T: ArrowTemporalType + ArrowNumericType,
i64: std::convert::From<T::Native>,
{
let mut b = Int32Builder::new(array.len());
match array.data_type() {
&DataType::Date32 | &DataType::Date64 | &DataType::Timestamp(_, None) => {
extract_component_from_array!(array, b, iso_week, week, value_as_datetime)
}
dt => return_compute_error_with!("week does not support", dt),
}
Ok(b.finish())
}
Now week not support Timestamp with timezone.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Activity
waitingkuo commentedon Nov 29, 2022
@Ted-Jiang i think this is solved in some pr. i added a test case to close this issue