Skip to content

Incorrect Numeric operations on MONTH_DAY_NANO interval type #1065

Closed

Description

@alamb

Describe the bug
Pointed out by @jorgecarleitao and @b41sh on #779 (comment)

Semantically, the numerics of an i128 are not the same as the numerics of (months,days,nanos) since i128 + i128 != (months, days,nanos) + (months, days,nanos).

The consequence of defining this type numerically here is that arithmetic kernels will accept this type, but they will yield a semantically incorrect result (e.g. i128 + i128 to sum two intervals of 1 month each).

To Reproduce
Do a numerical operation on two arrays of MonthDayNano type (for example add or subtract them). The arithmetic will be performed directly on the i128 representation rather than field by field

Expected behavior
The intervals should be calculated field by field; So for example to add two MonthDayNano fields, the kernels should add the nanoseconds, days and months separately

Additional context

Activity

  1. houqp commented on Dec 24, 2021

    @houqp
    Member

    It might be better to disallow arithmetic for this type because number of days in a month and number of nanos in a day is different depending on the reference point of time you are in. So there is no perfect way to handle it. Compute engines can choose their own tradeoffs and implement arithmetic and ordering downstream.

  2. self-assigned this
    on Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

arrowChanges to the arrow cratebug

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions