Skip to content

GH-3: Enable CI #17

Closed
raulcd wants to merge 8 commits into
apache:mainfrom
raulcd:GH-3
Closed

GH-3: Enable CI #17
raulcd wants to merge 8 commits into
apache:mainfrom
raulcd:GH-3

Conversation

@raulcd

@raulcd raulcd commented May 19, 2025

Copy link
Copy Markdown
Member

@raulcd

raulcd commented May 19, 2025

Copy link
Copy Markdown
Member Author

I've created an empty License and Notice files to bypass CI requirements. We should wait for:

and remove the temporary files.

@raulcd raulcd marked this pull request as ready for review May 19, 2025 18:13
@raulcd

raulcd commented May 19, 2025

Copy link
Copy Markdown
Member Author

@kou

kou commented May 19, 2025

Copy link
Copy Markdown
Member

I've merged #12 to unblock this.
Could you rebase on main?

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have a change for this. (It's blocked by #12. So I haven't shared it. Sorry.)
I opened #18 for reference.

Comment thread docker-compose.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread docker-compose.yml
name: ${ARCH}-debian-${DEBIAN}-ccache

services:
debian-js:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
debian-js:
debian:

Comment thread docker-compose.yml
Comment on lines +29 to +30
debian-ccache:
name: ${ARCH}-debian-${DEBIAN}-ccache

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to use ccache. We want to use jest instead:

Suggested change
debian-ccache:
name: ${ARCH}-debian-${DEBIAN}-ccache
jest-cache:
name: jest-cache

@kou kou mentioned this pull request May 20, 2025
@raulcd

raulcd commented May 20, 2025

Copy link
Copy Markdown
Member Author

I am closing this in favor of: #18

@raulcd raulcd closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable CI

2 participants