Refactor initialization for consistency #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2022
Merged
Instead, start refactoring things to follow a multi-step init similar to DuckDB: New(), then SetOption(), then Init(). Also, update the driver manager so it no longer requires a special entrypoint. Instead, just call AdbcDatabaseNew(), then set options to indicate the driver to use.
Make them more consistent and reduce the surface of the SQL-specific portion.
lidavidm
force-pushed
the
refactor-consistency
branch
from
e7d5c4a to
3b3f23f
Compare
davidhcoe
referenced
this pull request
in davidhcoe/arrow-adbc
Mar 18, 2024
add fetch results and batch traversing for cloud fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #5.