Refactor error handling #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard for the driver manager to allocate/free errors since it would have to manually intercept all calls. Also, it makes it hard to provide error messages when there is no driver. Move the error release callback to the error structure itself to make this easier.
This was referenced Jun 3, 2022
msrathore-db
added a commit
to msrathore-db/arrow-adbc
that referenced
this pull request
Nov 4, 2025
Added 5 targeted tests validating code review fixes: - Duplicate detection prevention (issue apache#5) - Atomic CTS replacement (issue apache#9) - Cleanup in finally block (issue apache#3) - Cancellable cleanup tasks (issue apache#7) - Concurrent CTS cleanup safety All tests use real objects (ConcurrentDictionary, CancellationTokenSource) without mocks, following existing CloudFetch test patterns. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard for the driver manager to allocate/free errors since it
would have to manually intercept all calls. Also, it makes it hard
to provide error messages when there is no driver. Move the error
release callback to the error structure itself to make this easier.