Skip to content

Conversation

@lidavidm
Copy link
Member

This fixes a regression in behavior. We only want to activate the new behavior if only one of driver or URI is set.

This fixes a regression in behavior.  We only want to activate the
new behavior if only one of driver or URI is set.
@lidavidm
Copy link
Member Author

@github-actions github-actions bot added this to the ADBC Libraries 22 milestone Dec 11, 2025
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also tested by hand that a pair like

      {{"uri", "anything://localhost"}, {"driver", "sqlite"}},

throws the sqlite driver's "failed to allocate memory" error.

@lidavidm lidavidm merged commit 0e4651c into apache:main Dec 14, 2025
78 of 84 checks passed
@lidavidm lidavidm deleted the uri branch December 14, 2025 02:16
eitsupi added a commit to eitsupi/arrow-adbc that referenced this pull request Dec 17, 2025
eitsupi added a commit to eitsupi/arrow-adbc that referenced this pull request Dec 17, 2025
paleolimbot pushed a commit that referenced this pull request Dec 18, 2025
…d of the cran version (#3817)

Related to #3789 and #3790

Looking at the logs, it seems that the current CI was using
adbcdrivermanager installed from CRAN, and testing of the latest driver
and driver manager combinations had not been performed.
This PR will make a change to ensure that adbcdrivermanager is installed
locally.

This required a minor change to prevent the bootstrap.R script from
failing with `pak::pkg_install("local::.")` or something else.

We can check the driver manager version via the logs of the
`r-lib/actions/setup-r-dependencies` step.

Before:

```
  ─ Session info ───────────────────────────────────────────────────────────────
   setting  value
   version  R version 4.5.2 (2025-10-31)
   os       Ubuntu 24.04.3 LTS
   system   x86_64, linux-gnu
   ui       X11
   language (EN)
   collate  C.UTF-8
   ctype    C.UTF-8
   tz       UTC
   date     2025-12-17
   pandoc   NA
   quarto   NA
  
  ─ Packages ───────────────────────────────────────────────────────────────────
   package           * version date (UTC) lib source
   adbcdrivermanager   0.21.0  2025-11-20 [1] RSPM
   base              * 4.5.2   2025-10-31 [3] local
```

After this change:

```
  ─ Session info ───────────────────────────────────────────────────────────────
   setting  value
   version  R version 4.5.2 (2025-10-31)
   os       Ubuntu 24.04.3 LTS
   system   x86_64, linux-gnu
   ui       X11
   language (EN)
   collate  C.UTF-8
   ctype    C.UTF-8
   tz       UTC
   date     2025-12-17
   pandoc   NA
   quarto   NA
  
  ─ Packages ───────────────────────────────────────────────────────────────────
   package           * version     date (UTC) lib source
   adbcdrivermanager   0.21.0.9000 2025-12-17 [1] local
   base              * 4.5.2       2025-10-31 [3] local
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants