Skip to content

Conversation

@lidavidm
Copy link
Member

No description provided.

@lidavidm
Copy link
Member Author

2025-12-10T19:46:05.2895787Z Running the tests in 'tests/testthat.R' failed.
2025-12-10T19:46:05.2896412Z Last 13 lines of output:
2025-12-10T19:46:05.2898632Z   Error in `adbc_database_set_options(database, options)`: INVALID_ARGUMENT: [Driver Manager] Invalid URI: missing scheme
2025-12-10T19:46:05.2899347Z   Backtrace:
2025-12-10T19:46:05.2899582Z       x
2025-12-10T19:46:05.2900171Z    1. +-adbcdrivermanager::adbc_database_init(adbcsqlite(), uri = temp_db) at test-adbcsqlite-package.R:108:3
2025-12-10T19:46:05.2900964Z    2. \-adbcsqlite:::adbc_database_init.adbcsqlite_driver_sqlite(...)
2025-12-10T19:46:05.2901804Z    3.   \-adbcdrivermanager::adbc_database_init_default(...)
2025-12-10T19:46:05.2902248Z    4.     +-adbcdrivermanager::with_adbc(...)
2025-12-10T19:46:05.2902830Z    5.     | \-base::force(code)
2025-12-10T19:46:05.2903430Z    6.     \-adbcdrivermanager::adbc_database_set_options(database, options)
2025-12-10T19:46:05.2904828Z    7.       \-adbcdrivermanager:::stop_for_error(status, error)
2025-12-10T19:46:05.2905321Z   
2025-12-10T19:46:05.2905600Z   [ FAIL 1 | WARN 0 | SKIP 0 | PASS 11 ]

https://github.com/lidavidm/arrow-adbc/actions/runs/20110742114/job/57707031337

@eitsupi
Copy link
Contributor

eitsupi commented Dec 11, 2025

The reason the issue doesn't reproduce in the CI of this repository may be because it uses the adbcdrivermanager on CRAN instead of the one on this monorepo.

@lidavidm
Copy link
Member Author

The reason the issue doesn't reproduce in the CI of this repository may be because it uses the adbcdrivermanager on CRAN instead of the one on this monorepo.

Ah! I didn't realize that! That seems like an oversight IMO...

@lidavidm
Copy link
Member Author

Superseded by #3790, I think

@eitsupi
Copy link
Contributor

eitsupi commented Dec 17, 2025

#3817 is an attempt to ensure that the driver manager is used in R tests.

I noticed in a previous PR that the driver manager installed from CRAN was being used in tests, but neglected to point that out.
Sorry!

paleolimbot pushed a commit that referenced this pull request Dec 18, 2025
…d of the cran version (#3817)

Related to #3789 and #3790

Looking at the logs, it seems that the current CI was using
adbcdrivermanager installed from CRAN, and testing of the latest driver
and driver manager combinations had not been performed.
This PR will make a change to ensure that adbcdrivermanager is installed
locally.

This required a minor change to prevent the bootstrap.R script from
failing with `pak::pkg_install("local::.")` or something else.

We can check the driver manager version via the logs of the
`r-lib/actions/setup-r-dependencies` step.

Before:

```
  ─ Session info ───────────────────────────────────────────────────────────────
   setting  value
   version  R version 4.5.2 (2025-10-31)
   os       Ubuntu 24.04.3 LTS
   system   x86_64, linux-gnu
   ui       X11
   language (EN)
   collate  C.UTF-8
   ctype    C.UTF-8
   tz       UTC
   date     2025-12-17
   pandoc   NA
   quarto   NA
  
  ─ Packages ───────────────────────────────────────────────────────────────────
   package           * version date (UTC) lib source
   adbcdrivermanager   0.21.0  2025-11-20 [1] RSPM
   base              * 4.5.2   2025-10-31 [3] local
```

After this change:

```
  ─ Session info ───────────────────────────────────────────────────────────────
   setting  value
   version  R version 4.5.2 (2025-10-31)
   os       Ubuntu 24.04.3 LTS
   system   x86_64, linux-gnu
   ui       X11
   language (EN)
   collate  C.UTF-8
   ctype    C.UTF-8
   tz       UTC
   date     2025-12-17
   pandoc   NA
   quarto   NA
  
  ─ Packages ───────────────────────────────────────────────────────────────────
   package           * version     date (UTC) lib source
   adbcdrivermanager   0.21.0.9000 2025-12-17 [1] local
   base              * 4.5.2       2025-10-31 [3] local
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants