Skip to content

fix(go/adbc/sqldriver): ignore NotImplemented errors for optional transaction options #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeroshade merged 1 commit into from
Dec 8, 2025
Merged

fix(go/adbc/sqldriver): ignore NotImplemented errors for optional transaction options #3759

zeroshade merged 1 commit into from
Dec 8, 2025

Conversation

@Mandukhai-Alimaa
Copy link
Contributor

@Mandukhai-Alimaa Mandukhai-Alimaa commented Nov 28, 2025

This change adds graceful handling for StatusNotImplemented errors when setting optional transaction features (isolation level and read-only mode), allowing transactions to work with drivers that don't implement these optional features.

@github-actions github-actions bot added this to the ADBC Libraries 22 milestone Nov 28, 2025
@wangfenjin
Copy link

wangfenjin commented Nov 30, 2025

this is great. and do we have plan to support isolation level in go flighsql driver similar to #3760 ?

@Mandukhai-Alimaa
Copy link
Contributor Author

Mandukhai-Alimaa commented Dec 2, 2025

Hi @wangfenjin, it seems that the Go Flight SQL driver currently does not support this. Please see below for more information.
apache/arrow#41840 https://github.com/apache/arrow/blob/02ade2c216d85a1070f9934188e1b4537ca1be33/format/FlightSql.proto#L1565-L1585

@zeroshade
Copy link
Member

zeroshade commented Dec 8, 2025

I'm a little concerned about us providing no feedback to the user at all when the driver doesn't support it (maybe print something to stderr? log it somehow?) but for now I think this is fine.

@zeroshade zeroshade merged commit bf523d1 into apache:main Dec 8, 2025
29 of 37 checks passed
@CurtHagenlocher
Copy link
Contributor

CurtHagenlocher commented Dec 8, 2025

I'm a little concerned about us providing no feedback to the user at all when the driver doesn't support it (maybe print something to stderr? log it somehow?) but for now I think this is fine.

#1243 would be nice for this ;).

@lidavidm
Copy link
Member

lidavidm commented Dec 9, 2025

This is for Go's sqldriver API so it would be that API that needs to support warnings

@lidavidm
Copy link
Member

lidavidm commented Dec 9, 2025

(But also yes I would like to support warnings in the ADBC API)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

@zeroshade zeroshade zeroshade approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

ADBC Libraries 22

Development

Successfully merging this pull request may close these issues.

5 participants

@Mandukhai-Alimaa @wangfenjin @zeroshade @CurtHagenlocher @lidavidm