fix(go/adbc/sqldriver): properly close resources #3731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoeba
approved these changes
Nov 19, 2025
Member
amoeba
left a comment
amoeba
left a comment
There was a problem hiding this comment.
Thanks. I was able to test again with the changes here and the issue no longer appears.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3728
This was a combination of two issues that are fixed in this PR:
sqldriver.Connectorneeds to implement theio.Closerinterface so thatsql.DB.Closewill call it and callCloseon theadbc.Databaseobject.rows.Closeneeds to also close the associatedstmt. In the case of at least one driver (the duckdb driver in associated issue) not closing thestmtled to the handle to the duckdb database not being dropped despite callingCloseon the database.