feat(csharp): rename .Tests to .Testing; add NuGet for other packages #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhcoe
requested review from
CurtHagenlocher,
kou and
lidavidm
as code owners
CurtHagenlocher
requested changes
Nov 19, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
I think the noted dependency change is causing a build failure.
| <PackageReference Include="System.Text.Json" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\test\Apache.Arrow.Adbc.Tests\Apache.Arrow.Adbc.Testing.csproj" /> |
Contributor
There was a problem hiding this comment.
Should the driver depend on a test project?
Contributor
Author
There was a problem hiding this comment.
doh, I was testing out something and added the reference back to the wrong project.
CurtHagenlocher
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames Apache.Arrow.Adbc.Tests.csproj to Apache.Arrow.Adbc.Testing.csproj, following the pattern like https://www.nuget.org/packages/Grpc.Core.Testing
Proposes publishing
as NuGet packages to be consumed by C# drivers in https://github.com/adbc-drivers/ and removing Apache.Arrow.Adbc.Drivers.FlightSql from NuGet publishing.