feat(csharp/Benchmarks): Add custom columns for CloudFetch benchmark metrics #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrics Add custom BenchmarkDotNet columns to display Peak Memory, Total Rows, and Total Batches in the summary table instead of requiring users to check console output. Changes: - Add BenchmarkMetrics class to store peak memory, total rows, and total batches - Store metrics in temp file (cloudfetch_benchmark_metrics.json) for cross-process access - Update PeakMemoryColumn to read from temp file instead of static dictionary - Add TotalRowsColumn to display total rows processed - Add TotalBatchesColumn to display total batches processed - Register all three custom columns in CloudFetchBenchmarkRunner - Update README with .NET Framework 4.7.2 instructions for Power BI testing - Update README with new metrics column documentation and examples This fixes the "See previous console output" issue where custom columns couldn't access metrics because BenchmarkDotNet runs iterations in separate processes. The temp file approach ensures metrics are available when generating the final summary table. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CurtHagenlocher
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add custom BenchmarkDotNet columns to display Peak Memory, Total Rows, and Total Batches in the summary table instead of requiring users to check console output.
Changes
BenchmarkMetricsclass to store peak memory, total rows, and total batchescloudfetch_benchmark_metrics.json) for cross-process accessPeakMemoryColumnto read from temp file instead of static dictionaryTotalRowsColumnto display total rows processedTotalBatchesColumnto display total batches processedCloudFetchBenchmarkRunnerProblem Solved
This fixes the "See previous console output" issue where custom columns couldn't access metrics because BenchmarkDotNet runs iterations in separate processes. The temp file approach ensures metrics are available when generating the final summary table.
Before
After
Testing
🤖 Generated with Claude Code