-
Notifications
You must be signed in to change notification settings - Fork 173
feat(csharp/Benchmarks): Add CloudFetch E2E performance benchmark #3660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sreekanth Vadigi <[email protected]>
Add comprehensive E2E benchmark for Databricks CloudFetch with real cluster testing. Features: - Real E2E benchmark against actual Databricks cluster with configurable query via JSON config file - Power BI consumption simulation with batch-size proportional delays (5ms per 10K rows) - Peak memory tracking using Process.WorkingSet64 - Optimized iteration counts (1 warmup + 3 actual) for faster execution - Custom peak memory column in results table with console output reference - Hides confusing Error/StdDev columns from summary Configuration via DATABRICKS_TEST_CONFIG_FILE environment variable pointing to JSON with: - uri: Databricks warehouse URI - token: Access token - query: SQL query to execute Run with: export DATABRICKS_TEST_CONFIG_FILE=/path/to/config.json dotnet run -c Release --project Benchmarks/Benchmarks.csproj --framework net8.0 CloudFetchBenchmarkRunner -- --filter "*" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…ated Telemetry files - Add example console output and summary table to CloudFetch benchmark README - Remove Telemetry design documents that are not relevant to this PR 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…EBenchmark - Remove references to deleted synthetic benchmarks - Update running instructions to reflect only E2E benchmark - Clean up key metrics section to remove synthetic benchmark comparisons - Fix Gen2 and Allocated values in example output 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CurtHagenlocher
requested changes
Nov 3, 2025
Contributor
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you please add a comment to README.md with the Apache license so it passes the checkin test? You can see an examples in the existing .md files of how to format the comment.
Add Apache license comment to CloudFetch benchmark README to pass checkin test as requested by reviewer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
CurtHagenlocher
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive E2E benchmark for Databricks CloudFetch to measure real-world performance with actual cluster and configurable queries.
Changes
CloudFetchRealE2EBenchmark: Real E2E benchmark against actual Databricks cluster
CloudFetchBenchmarkRunner: Standalone runner for CloudFetch benchmarks
README.md: Documentation for running and understanding the benchmarks
Configuration
Benchmark requires
DATABRICKS_TEST_CONFIG_FILEenvironment variable pointing to JSON config:{ "uri": "https://your-workspace.cloud.databricks.com/sql/1.0/warehouses/xxx", "token": "dapi...", "query": "select * from main.tpcds_sf1_delta.catalog_sales" }Run Command
Example Output
Console output during benchmark execution:
Summary table:
Key Metrics:
Test Plan
🤖 Generated with Claude Code