feat(csharp/src/Drivers/Databricks): consolidate LZ4 decompression logic and improve resource disposal #3649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic and improve resource disposal This commit consolidates LZ4 decompression code paths and ensures proper resource cleanup across both CloudFetch and non-CloudFetch readers. **Changes:** - Add configurable buffer size parameter to `Lz4Utilities.DecompressLz4()` - Add async variant `DecompressLz4Async()` for CloudFetch pipeline - Update CloudFetchDownloader to use shared `Lz4Utilities.DecompressLz4Async()` - Add proper `using` statements for MemoryStream disposal **Benefits:** - Reduces code duplication (~12 lines consolidated in CloudFetchDownloader) - Both code paths now share the same decompression implementation - Improves memory hygiene with explicit MemoryStream disposal - Maintains cancellation token support in async path - Preserves existing telemetry and performance characteristics **Technical Details:** - Default buffer size remains 80KB (81920 bytes) - Async version returns `(byte[] buffer, int length)` tuple for efficient MemoryStream wrapping - Buffer validity preserved after MemoryStream disposal via reference counting - No behavioral changes - purely refactoring and cleanup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…with default buffer size Add a convenience overload of DecompressLz4Async that uses the default buffer size, matching the pattern of the synchronous DecompressLz4 method. This improves code consistency and simplifies call sites. **Changes:** - Add `DecompressLz4Async(byte[], CancellationToken)` overload that delegates to the full version with DefaultBufferSize - Update CloudFetchDownloader to use the simpler overload, removing hardcoded buffer size **Benefits:** - API symmetry between sync and async methods - Cleaner call sites (no need to specify buffer size when default is acceptable) - Maintains same functionality and performance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Contributor
|
Take a look at #3650; if you keep the downloaded buffer as a |
CurtHagenlocher
approved these changes
Oct 29, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates LZ4 decompression code paths and ensures proper resource cleanup across both CloudFetch and non-CloudFetch readers in the Databricks C# driver.
Changes
Lz4Utilities.cs
DecompressLz4()DecompressLz4Async()for CloudFetch pipelineusingstatements for MemoryStream disposalCloudFetchDownloader.cs
Lz4Utilities.DecompressLz4Async()Benefits
Technical Details
(byte[] buffer, int length)tuple for efficient MemoryStream wrapping in CloudFetchTesting
🤖 Generated with Claude Code