fix(csharp/src/Drivers/BigQuery): handle dispose of Statement before Stream #3608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@davidhcoe - Please review if you have a chance. |
| { | ||
| context.Dispose(); | ||
| } | ||
| // Clear the registry and let holder of the contexts dispose themselves |
Contributor
There was a problem hiding this comment.
The comment seems to describe the reason for this change, but without the context of the previously-checked-in version it doesn't seem helpful for understanding the code moving forward.
What does it mean for the context to dispose itself?
Contributor
Author
There was a problem hiding this comment.
Modified to implement a more robust dispose on the ContextRegistry. Removed unnecessary comment.
Does this make better sense?
CurtHagenlocher
approved these changes
Oct 22, 2025
birschick-bq
deleted the
dev/birschick-bq/fix-bigquery-canceltoken-disposed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix handles the possibility that the parent statement disposes before the created stream.