feat(c/driver/postgresql): Implement StatementGetParameterSchema #3579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Oct 16, 2025
| void TestSqlPrepareErrorParamCountMismatch() { GTEST_SKIP() << "Not yet implemented"; } | ||
| void TestSqlPrepareGetParameterSchema() { GTEST_SKIP() << "Not yet implemented"; } | ||
|
|
||
| void TestSqlPrepareGetParameterSchema() { |
Member
There was a problem hiding this comment.
You should be able to just remove the line and let the base class's test run.
c/driver/postgresql/statement.cc
Outdated
Comment on lines
766
to
767
| InternalAdbcSetError(error, "%s", | ||
| "[libpq] Must SetSqlQuery before GetParameterSchema"); |
Member
There was a problem hiding this comment.
Suggested change
| InternalAdbcSetError(error, "%s", | |
| "[libpq] Must SetSqlQuery before GetParameterSchema"); | |
| InternalAdbcSetError(error, "[libpq] Must SetSqlQuery before GetParameterSchema"); |
Member
|
There also appears to be a memory leak according to the integration tests |
lidavidm
approved these changes
Oct 17, 2025
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
Dec 7, 2025
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment)
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
Dec 7, 2025
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment) This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time.
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
Dec 7, 2025
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment) This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time.
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
Dec 7, 2025
This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment) This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time.
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
Dec 7, 2025
feat: bump adbc-driver-postgresql>=1.9.0 and Python>=3.10.0 This increases the minimum version of adbc-driver-postgresql to 1.9.0. While we could support older versions still - We run up against GitHub actions limits by trying to test absolutely every version. Assuming adbc-driver-postgresql is semver, each minor version is backward compatible, so it shouldn't be a problem for client code to upgrade. - And it makes it easier in documentation, tests, and suspect future code that we can assume that apache/arrow-adbc#3579 is part of adbc-driver-postgresql, which allows preparing queries to return as-accurate-as-possible type information for bind parameters in queries, which addresses at least in part the issues raised in apache/arrow-adbc#2865 (comment) This itself requires a bump to the minimum version of Python to 3.10.0. While slightly unfortunate, Python 3.9 is EOL at the time of writing, and can't support everything for ever: suspect there are better ways to use time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement StatementGetParameterSchema and add tests.
Newly added test passes
All the other PostgreSQL driver tests pass
Closes #2880