feat(go/adbc/driver/snowflake): Add option to disable vectorized scanner #3555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
commented
Oct 10, 2025
| OptionStatementIngestTargetFileSize = "adbc.snowflake.statement.ingest_target_file_size" | ||
| OptionStatementIngestCompressionCodec = "adbc.snowflake.statement.ingest_compression_codec" // TODO(GH-1473): Implement option | ||
| OptionStatementIngestCompressionLevel = "adbc.snowflake.statement.ingest_compression_level" // TODO(GH-1473): Implement option | ||
| OptionStatementVectorizedScanner = "adbc.snowflake.statement.use_vectorized_scanner" |
Contributor
Author
There was a problem hiding this comment.
Hmm... should probably reference ingestion. Maybe ingest_use_vectorized_scanner?
Member
There was a problem hiding this comment.
Sounds reasonable to me.
(Also not quite an issue for here but the adbc. prefix is probably redundant)
lidavidm
reviewed
Oct 13, 2025
| }) | ||
|
|
||
| // Create a temporary stage, we can't start uploading until it has been created | ||
| createTemporaryStageStmt := fmt.Sprintf(createTemporaryStageTmpl, "") |
Member
There was a problem hiding this comment.
Why don't we handle the option here?
Contributor
Author
There was a problem hiding this comment.
My read of the code is that this only ever binds a single record so I don't know why you'd ever need the vectorized scanner.
Member
There was a problem hiding this comment.
It could bind a single very large record :)
Contributor
Author
There was a problem hiding this comment.
Added this for consistency and compatibility, though I'm skeptical that there's any real-world value ;).
zeroshade
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vectorized scanner seems to be causing performance issues under some circumstances. Add an option to disable it.