feat(csharp/src/Drivers/Databricks): Used connection param of batchSize for cloudFetch #3518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default value for BatchSize to 2 million.
| private bool enablePKFK; | ||
| private bool runAsyncInThrift; | ||
|
|
||
| public new long BatchSize { get; private set; } = DatabricksBatchSizeDefault; |
Contributor
There was a problem hiding this comment.
Searching from web, this new keyword is hiding the base class impl, not truly overriding it. Which means if the object is referenced by base class type it will still call base class function.
Can we change the base to virtual so we can call this override?
| /// </summary> | ||
| internal class DatabricksStatement : SparkStatement, IHiveServer2Statement | ||
| { | ||
| private const long DatabricksBatchSizeDefault = 2000000; |
Contributor
There was a problem hiding this comment.
Let's add a comment of explaining why this is set to 2 million.
msrathore-db
changed the title
CurtHagenlocher
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used connection param of batchSize for cloudFetch. Changed the default value of the param to 2 million instead of 50k.
PECO-2732