feat(csharp/src/Drivers/BigQuery): Add support for specifying a location #3494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
approved these changes
Sep 29, 2025
Contributor
CurtHagenlocher
left a comment
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks!
While I think this change is good, is it our expectation that the user will have to enter an additional parameter when connecting to BigQuery using this driver? Is this something whose default value can be derived from the project or the user account in some fashion so that the user doesn't need to enter it? How does the Go BigQuery driver do this?
Contributor
Author
|
If the user doesn't specify (which we don't today), then the API defaults to US. I will see whether the Go driver deals with this at all. |
Contributor
Author
|
It basically does the same thing: .I tried to determine location based on the project ID, but that is not something that is supported. |
Contributor
|
Do we have any way to figure out what the ODBC driver is doing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current iteration, no DefaultLocation is specified for the internal BigQueryClient. Since this is not specified, the BigQuery API makes this default to "US" which is causing failures for some users. This PR adds a new parameter to set the DefaultLocation for the BigQueryClient, which then uses that same value for creating datasets and other location-based activitities.