fix: resolve Goroutine leak in database connection close #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceNu1l
force-pushed
the
fix/goroutine-leak
branch
2 times, most recently
from
eb0f745 to
c5254f4
Compare
bruceNu1l
changed the title
Member
|
Looks like there's some linting that needs to get fixed before I can merge. |
… leak in database connection close
bruceNu1l
force-pushed
the
fix/goroutine-leak
branch
from
c5254f4 to
a15ede1
Compare
Contributor
Author
@zeroshade Yes, I've fixed the linting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection is opened via databaseImpl, the cache clientCache initializes
*flightsql.Client objects which require proper cleanup on connection close to
prevent Goroutine leaks.
Previously, closing a connection released only 3 of the 6 Goroutines created per
connection, leaving 3 Goroutines associated with the cached client unmanaged.
This resulted in accumulated Goroutine leaks over time.
The fix ensures all Goroutines are properly cleaned up when connections are closed.