fix(c/driver_manager): ensure CONDA_PREFIX search builds #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
gh-3427
branch
3 times, most recently
from
2170ee8 to
c7b37b3
Compare
zeroshade
reviewed
Sep 16, 2025
| } | ||
|
|
||
| #if ADBC_CONDA_BUILD | ||
| #if defined(ADBC_CONDA_BUILD) |
Member
There was a problem hiding this comment.
So, this was set up this way because of the R build which uses -DADBC_CONDA_BUILD=${CONDA_BUILD} because of how Makevars in R doesn't allow a bunch of different Make constructs.
So changing this like this will result in this being built for the R driver manager even when not using CONDA_BUILD
Member
Author
There was a problem hiding this comment.
It would be nice to document that :) I'll change it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3427.