-
Notifications
You must be signed in to change notification settings - Fork 173
feat(csharp/src/Telemetry/Traces/Exporters): refactor and improve performance of file exporter #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(csharp/src/Telemetry/Traces/Exporters): refactor and improve performance of file exporter #3397
Conversation
…formance of file exporter
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feedback left.
csharp/test/Telemetry/Traces/Exporters/FileExporter/FileExporterTests.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/FileExporter.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/FileExporter.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/TracingFile.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/TracingFile.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/TracingFile.cs
Outdated
Show resolved
Hide resolved
csharp/src/Telemetry/Traces/Exporters/FileExporter/FileExporter.cs
Outdated
Show resolved
Hide resolved
|
@birschick-bq can you rebase this to see if that resolves the problem with the failing tests? |
@CurtHagenlocher Thoughts? |
I'll check this in as-is and let's create a separate PR just to enable the tests. |
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Refactors and (significantly) improves performance of the file exporter.
System.Threading.Channelsto improve clarity and shutdown handling.OnForceFlushto try to flush messages when needed.Benefits