docs: minor improvements to driver_manifests.rst #3394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows up as a blockquote without this extra space. With the space, it now shows up as a sublist which is what I think it should be.
amoeba
force-pushed
the
docs/driver-manifests-page-edits
branch
from
4a056ec to
63005a6
Compare
lidavidm
approved these changes
Sep 5, 2025
| function, it can be indicated with this option. | ||
| .. note:: In addition to the ``driver`` option, there is also an ``entrypoint`` | ||
| option that should be used if the driver uses a non-default | ||
| entrypoint. |
Member
There was a problem hiding this comment.
Should "entrypoint" get its own glossary term?
Member
Author
There was a problem hiding this comment.
I suppose it could, so we can be clear about what we mean by it.
Member
Author
There was a problem hiding this comment.
I want to check if my linking to AdbcDriverInitFunc does something reasonable real quick...
Member
Author
There was a problem hiding this comment.
I changed it from func -> type.
ianmcook
approved these changes
Sep 5, 2025
lidavidm
approved these changes
Sep 5, 2025
Member
It should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #3388
This PR makes a few improvements to the driver_manifests.rst page. Mainly, it reworks a bit of the start for clarity. I also found some issues later down in the doc which I've fixed as well.